Peer Review History

Original SubmissionJanuary 14, 2020
Decision Letter - Dina Schneidman-Duhovny, Editor

Dear Dr. Chandrasekaran,

Thank you very much for submitting your manuscript "Accelerating Prediction of Chemical Shift of Protein Structures on GPUs" for consideration at PLOS Computational Biology. As with all papers reviewed by the journal, your manuscript was reviewed by members of the editorial board and by several independent reviewers. The reviewers appreciated the attention to an important topic. Based on the reviews, we are likely to accept this manuscript for publication, providing that you modify the manuscript according to the review recommendations.

Please prepare and submit your revised manuscript within 30 days. If you anticipate any delay, please let us know the expected resubmission date by replying to this email. 

When you are ready to resubmit, please upload the following:

[1] A letter containing a detailed list of your responses to all review comments, and a description of the changes you have made in the manuscript. Please note while forming your response, if your article is accepted, you may have the opportunity to make the peer review history publicly available. The record will include editor decision letters (with reviews) and your responses to reviewer comments. If eligible, we will contact you to opt in or out

[2] Two versions of the revised manuscript: one with either highlights or tracked changes denoting where the text has been changed; the other a clean version (uploaded as the manuscript file).

Important additional instructions are given below your reviewer comments.

Thank you again for your submission to our journal. We hope that our editorial process has been constructive so far, and we welcome your feedback at any time. Please don't hesitate to contact us if you have any questions or comments.

Sincerely,

Dina Schneidman-Duhovny

Software Editor

PLOS Computational Biology

Dina Schneidman-Duhovny

Software Editor

PLOS Computational Biology

***********************

A link appears below if there are any accompanying review attachments. If you believe any reviews to be missing, please contact ploscompbiol@plos.org immediately:

[LINK]

Reviewer's Responses to Questions

Comments to the Authors:

Please note here if the review is uploaded as an attachment.

Reviewer #1: This work present a systematic report that accelerate the PPM_One program by implementing portable optimization using OpenACC. It includes detailed description of the process helped improved the efficiency of the PPM_One orders of magnitude. It will greatly benefit the NMR communities and structural biology work involving NMR methods. The manuscript is nearly ready for publication, in my opinion. Here are some minor comments:

1. Page 2-3, Section "Overview of the Scientific Problems: Chemical shift Prediction: The citations in the first three paragraphs do not show up corrected. Please correct them.

2. Page 6, the end of paragraph 4: The speed-up will be discussed in more detail in Section 3.2. However, sections are not numbered, no idea which this refers to.

3. Page 7, first sentence of paragraph 2: The function getani() represents the compute region for calculating the chemical shift due to magnetic anisotropy. This sentence may need revision.

4. Table 1. The times for 6.8m atoms are longer than 5m atoms, which is easy to understand. However, why is it longer than 11.3m atoms? Any particular reason? Would love to see the explanation. Or maybe this reveals there is something else need optimization?

Reviewer #2: The manuscript at high level is very well organized and written. This work will definitely help other MD application developers think of using / adapting to programming models such as OpenACC to accelerate their applications, without having to delve into the nitty-gritty's of CUDA.

Minor revisions needed in the abstract and throughout the paper, comments indicated in the pdf (please open using Adobe Reader or similar).

Comments:

1. Be explicit in the abstract that there was major refactoring on the cpu side of the code happened as well before accelerating the code to the GPUs. Just 14hrs to 46secs seems like the code was really really bad, and the comparison is not appropriate. Recommend tweaking the statement a bit to reflect the changes (note: this was clear in the results section but not in the abstract).

2. Some citations are missing, Fig 1 was missing (I think at least, not in the pdf that was uploaded), also recommend running the manuscript through Grammarly (or similar) for grammatical error fixes.

3. Are their plans of running such simulations / modeling on larger systems with a higher (and complex) node count and what do the authors think of as a challenge when running similar workloads with OpenACC + MPI (or OpenMPI) ? Maybe something along these lines in a future work, or ongoing work directions would be an appropriate addition to this manuscript.

4. Recommend outlining the challenges of accelerating and porting such an application using OpenACC in a subsection, this will help other MD app developers to take that leap.

Reviewer #3: The manuscript describes a significant improvement on the run time of a chemical shift prediction program.

Chemical shift prediction is an important area of ongoing research to leverage the large amount of data available from NMR experiments of protein. The manuscript does a very good job of addressing the case of solid-state NMR, which can tackle large protein assemblies. The test models were chosen well and demonstrate the challenge associated with chemical shift prediction.

The results show important acceleration gains achieved, and the RMSD comparison clearly indicates a successful implementation. As such this is a significant contribution to the field.

One minor suggestion is that the authors include a brief comment on how successful PPM_One is when compared to experimental NMR results (if available) for the various chosen models.

**********

Have all data underlying the figures and results presented in the manuscript been provided?

Large-scale datasets should be made available via a public repository as described in the PLOS Computational Biology data availability policy, and numerical data that underlies graphs or summary statistics should be provided in spreadsheet form as supporting information.

Reviewer #1: Yes

Reviewer #2: Yes

Reviewer #3: Yes

**********

PLOS authors have the option to publish the peer review history of their article (what does this mean?). If published, this will include your full peer review and any attached files.

If you choose “no”, your identity will remain anonymous but your review may still be made public.

Do you want your identity to be public for this peer review? For information about this choice, including consent withdrawal, please see our Privacy Policy.

Reviewer #1: No

Reviewer #2: No

Reviewer #3: No

Figure Files:

While revising your submission, please upload your figure files to the Preflight Analysis and Conversion Engine (PACE) digital diagnostic tool, https://pacev2.apexcovantage.com. PACE helps ensure that figures meet PLOS requirements. To use PACE, you must first register as a user. Then, login and navigate to the UPLOAD tab, where you will find detailed instructions on how to use the tool. If you encounter any issues or have any questions when using PACE, please email us at figures@plos.org.

Data Requirements:

Please note that, as a condition of publication, PLOS' data policy requires that you make available all data used to draw the conclusions outlined in your manuscript. Data must be deposited in an appropriate repository, included within the body of the manuscript, or uploaded as supporting information. This includes all numerical values that were used to generate graphs, histograms etc.. For an example in PLOS Biology see here: http://www.plosbiology.org/article/info%3Adoi%2F10.1371%2Fjournal.pbio.1001908#s5.

Reproducibility:

To enhance the reproducibility of your results, PLOS recommends that you deposit laboratory protocols in protocols.io, where a protocol can be assigned its own identifier (DOI) such that it can be cited independently in the future. For instructions see http://journals.plos.org/ploscompbiol/s/submission-guidelines#loc-materials-and-methods

Attachments
Attachment
Submitted filename: ppm_plos_chandrasekaran.pdf
Revision 1

Attachments
Attachment
Submitted filename: Author_Responses_PCOMPBIOL-D-20-00060.pdf
Decision Letter - Dina Schneidman-Duhovny, Editor

Dear Dr. Chandrasekaran,

We are pleased to inform you that your manuscript 'Accelerating Prediction of Chemical Shift of Protein Structures on GPUs: Using OpenACC' has been provisionally accepted for publication in PLOS Computational Biology.

Before your manuscript can be formally accepted you will need to complete some formatting changes, which you will receive in a follow up email. A member of our team will be in touch with a set of requests.

Please note that your manuscript will not be scheduled for publication until you have made the required changes, so a swift response is appreciated.

IMPORTANT: The editorial review process is now complete. PLOS will only permit corrections to spelling, formatting or significant scientific errors from this point onwards. Requests for major changes, or any which affect the scientific understanding of your work, will cause delays to the publication date of your manuscript.

Should you, your institution's press office or the journal office choose to press release your paper, you will automatically be opted out of early publication. We ask that you notify us now if you or your institution is planning to press release the article. All press must be co-ordinated with PLOS.

Thank you again for supporting Open Access publishing; we are looking forward to publishing your work in PLOS Computational Biology. 

Best regards,

Dina Schneidman-Duhovny

Software Editor

PLOS Computational Biology

***********************************************************

Formally Accepted
Acceptance Letter - Dina Schneidman-Duhovny, Editor

PCOMPBIOL-D-20-00060R1

Accelerating Prediction of Chemical Shift of Protein Structures on GPUs: Using OpenACC

Dear Dr Chandrasekaran,

I am pleased to inform you that your manuscript has been formally accepted for publication in PLOS Computational Biology. Your manuscript is now with our production department and you will be notified of the publication date in due course.

The corresponding author will soon be receiving a typeset proof for review, to ensure errors have not been introduced during production. Please review the PDF proof of your manuscript carefully, as this is the last chance to correct any errors. Please note that major changes, or those which affect the scientific understanding of the work, will likely cause delays to the publication date of your manuscript.

Soon after your final files are uploaded, unless you have opted out, the early version of your manuscript will be published online. The date of the early version will be your article's publication date. The final article will be published to the same URL, and all versions of the paper will be accessible to readers.

Thank you again for supporting PLOS Computational Biology and open-access publishing. We are looking forward to publishing your work!

With kind regards,

Sarah Hammond

PLOS Computational Biology | Carlyle House, Carlyle Road, Cambridge CB4 3DN | United Kingdom ploscompbiol@plos.org | Phone +44 (0) 1223-442824 | ploscompbiol.org | @PLOSCompBiol

Open letter on the publication of peer review reports

PLOS recognizes the benefits of transparency in the peer review process. Therefore, we enable the publication of all of the content of peer review and author responses alongside final, published articles. Reviewers remain anonymous, unless they choose to reveal their names.

We encourage other journals to join us in this initiative. We hope that our action inspires the community, including researchers, research funders, and research institutions, to recognize the benefits of published peer review reports for all parts of the research system.

Learn more at ASAPbio .