Peer Review History
| Original SubmissionApril 18, 2020 |
|---|
|
PONE-D-20-11213 A GPU-Based Caching Strategy for Multi-Material Linear Elastic FEM on Regular Grids PLOS ONE Dear Dr Dahmen, Thank you for submitting your manuscript to PLOS ONE. After careful consideration, we feel that it has merit but does not fully meet PLOS ONE’s publication criteria as it currently stands. Therefore, we invite you to submit a revised version of the manuscript that addresses the points raised during the review process. The major comment (among many) is the lack of rigorous validation of the method presented as well as the observation that performance comparisons seem not to be inconsistent. Detailed reviewers' comments are attached below as well as in the pdf attachment. We would appreciate receiving your revised manuscript by Jun 28 2020 11:59PM. When you are ready to submit your revision, log on to https://www.editorialmanager.com/pone/ and select the 'Submissions Needing Revision' folder to locate your manuscript file. If you would like to make changes to your financial disclosure, please include your updated statement in your cover letter. To enhance the reproducibility of your results, we recommend that if applicable you deposit your laboratory protocols in protocols.io, where a protocol can be assigned its own identifier (DOI) such that it can be cited independently in the future. For instructions see: http://journals.plos.org/plosone/s/submission-guidelines#loc-laboratory-protocols Please include the following items when submitting your revised manuscript:
Please note while forming your response, if your article is accepted, you may have the opportunity to make the peer review history publicly available. The record will include editor decision letters (with reviews) and your responses to reviewer comments. If eligible, we will contact you to opt in or out. We look forward to receiving your revised manuscript. Kind regards, Anotida Madzvamuse, Dphil, MSc, MSC-ED, BSc (Hon) Academic Editor PLOS ONE Journal Requirements: When submitting your revision, we need you to address these additional requirements. 1. Please ensure that your manuscript meets PLOS ONE's style requirements, including those for file naming. The PLOS ONE style templates can be found at https://journals.plos.org/plosone/s/file?id=wjVg/PLOSOne_formatting_sample_main_body.pdf and https://journals.plos.org/plosone/s/file?id=ba62/PLOSOne_formatting_sample_title_authors_affiliations.pdf 2. Please note that PLOS ONE has specific guidelines on software sharing (http://journals.plos.org/plosone/s/materials-and-software-sharing#loc-sharing-software) for manuscripts whose main purpose is the description of a new software or software package. In this case, new software must conform to the Open Source Definition (https://opensource.org/docs/osd) and be deposited in an open software archive. Please see http://journals.plos.org/plosone/s/materials-and-software-sharing#loc-depositing-software for more information on depositing your software. 3. Please ensure that all datasets used for testing are referenced and linked to in the manuscript as well as in the Data availability statement. 4. Please ensure that you refer to Figure 5 in your text as, if accepted, production will need this reference to link the reader to the figure. Additional Editor Comments (if provided): [Note: HTML markup is below. Please do not edit.] Reviewers' comments: Reviewer's Responses to Questions Comments to the Author 1. Is the manuscript technically sound, and do the data support the conclusions? The manuscript must describe a technically sound piece of scientific research with data that supports the conclusions. Experiments must have been conducted rigorously, with appropriate controls, replication, and sample sizes. The conclusions must be drawn appropriately based on the data presented. Reviewer #1: Partly Reviewer #2: Yes Reviewer #3: Yes ********** 2. Has the statistical analysis been performed appropriately and rigorously? Reviewer #1: N/A Reviewer #2: N/A Reviewer #3: N/A ********** 3. Have the authors made all data underlying the findings in their manuscript fully available? The PLOS Data policy requires authors to make all data underlying the findings described in their manuscript fully available without restriction, with rare exception (please refer to the Data Availability Statement in the manuscript PDF file). The data should be provided as part of the manuscript or its supporting information, or deposited to a public repository. For example, in addition to summary statistics, the data points behind means, medians and variance measures should be available. If there are restrictions on publicly sharing data—e.g. participant privacy or use of data from a third party—those must be specified. Reviewer #1: Yes Reviewer #2: Yes Reviewer #3: Yes ********** 4. Is the manuscript presented in an intelligible fashion and written in standard English? PLOS ONE does not copyedit accepted manuscripts, so the language in submitted articles must be clear, correct, and unambiguous. Any typographical or grammatical errors should be corrected at revision, so please note any specific errors here. Reviewer #1: Yes Reviewer #2: Yes Reviewer #3: Yes ********** 5. Review Comments to the Author Please use the space provided to explain your answers to the questions above. You may also include additional comments for the author, including concerns about dual publication, research ethics, or publication ethics. (Please upload your review as an attachment if it exceeds 20,000 characters) Reviewer #1: The review comments are attached as a PDF file. Reviewer #2: The contribution is well-written, and describes an interesting application of GPU accelerated finite-element solution procedure for linear elasticity. Despite the application on the tibia, the link to the biomedical practice is very weak. I think that the manuscript should at least provide the PDE from a balance of momentum, Hooke's Law and the link to the displacements, as well as the boundary conditions. Furthermore, I think that the authors should show some computed results over the domain of computation in order to illustrate a stronger link to the biomedical practice. Next to these comments, which should not be too difficult to incorporate into this manuscript, I have the following more detailed points: 1. line 35: I would also mention 'symmetric' because the linear operator in the PDE for the momentum balance is self-adjoint, Furthermore, only if all boundaries that are considered are free (or are force-boundary conditions), then the resulting discretisation matrix will be positive semi-definite, else it will be positive definite (the same holds for the continuous operator). 2. Regarding the text and explanation near equation (1), it may be helpful to the PONE reader to add an illustrative figure to describe the 2D case. Probably a 3D illustration could end up a bit messy. 3. line 264-5: the residual error that has been introduced in equation (2) is not an absolute but a relative residual error. 4. Line 276: I would replace 'simulation' with 'iterative procedure' 5. Line 279: In the explanation of the averaged error, it may be good to add a link to the scaled L2-norm over the portion of the domain where the error is nonzero (f <> 0), you might as well refer to the L2 functional as an integration of the portion of the domain where the error is nonzero. In fact this is what your error is. (error = 1/N sum_j (f_j <> 0) (f_j - Au_j)^2, where N represents the number of nodes where f_j <> 0. This is just a matter of terminology. 6. I would replace several occurrences of 'compute time' with 'computation time' 7. Figure 5: An absolute error in terms of a percentage is reported. How can an absolute error be expressed in terms of percentages? Representations in percentages are always relative, I think. 8. Figure 5 and the text describing the figure: Does the level for the convergence criterion depend on the highest mesh resolution used in the simulation? Please, comment on this issue. Because now the results are presented as some 'absolute numbers', which are very much depending on the problem and its discretisation. 9. The test with a randomised choice of stiffness values throughout the domain of computation are appreciated. How does the method perform if the ratio of elasticity ratios becomes very large, say 10^7? For this case, you might have to use deflation preconditioned methods. Please, comment a bit on this issue (I don't expect that the authors solve this problem, but I expect some comments and/or an example computation only). Reviewer #3: The paper presents a matrix-free FEM simulation of linear elastic problems for applications that rely on a very high grid resolution obtained from different imaging technologies. The proposed scheme combines a representative range of pre-computed element stiffness matrices and the computing capacities of GPUs to solve the displacement equation. The presented research is very interesting and offers great potential in different computational fields. The manuscript deserves to be published after a number of improvements are taken. As general comment, the Materials and Methods section would benefit from a more systematic and rigorous presentation of the different elements that compose it. Additional comments, some in relation with the previous one: 1. The given description of the partition scheme (lines 187-191) may be confused with the element connectivity. It is also not sufficiently clear why the update region consists of 6x6x6 vertices. 2. Figure 2 seems to be incomplete. Consider editing or writing the pseudocode in algorithmic form. 3. The multigrid scheme should be presented in more detail, including number of refinement levels, cycle scheme, etc. What is the specific pre-defined minimum problem size mentioned in line 212? Is it the same for the three test cases given in the results? Shall the "additional levels of detail" be understood as refinement levels? 4. For the sake of completeness and fair comparison, the characteristics of the linear solver used in the Abaqus solution should be given (iterative method, tolerances, convergence criterion, ...). 5. When comparing the execution time against that using Abaqus (Table 2), is the "reduced" calculation of the residual error (on one node per cell) used? Have the execution times been measured using the full computation of the residual error? If so, why such a reduction in the computational cost should be disregarded in discussion of the above-mentioned table? 6. A detailed look at Figure 5 (the comparison of the AlSi system with the solution given by the software Abaqus) raises a number of issues that should be addressed with more detail in the text. First and most important, it seems that there is a critical value for the tolerance above which the scheme does not capture realistic features of the solution and below which the numerical solution does not improve. Is the same trend observed when the solution to the dual steel phase is compared against the Abaqus solution? A better way to address this issue might be to consider a relevant analytic test problem and perform a convergence study on it. ********** 6. PLOS authors have the option to publish the peer review history of their article (what does this mean?). If published, this will include your full peer review and any attached files. If you choose “no”, your identity will remain anonymous but your review may still be made public. Do you want your identity to be public for this peer review? For information about this choice, including consent withdrawal, please see our Privacy Policy. Reviewer #1: No Reviewer #2: No Reviewer #3: No [NOTE: If reviewer comments were submitted as an attachment file, they will be attached to this email and accessible via the submission site. Please log into your account, locate the manuscript record, and check for the action link "View Attachments". If this link does not appear, there are no attachment files to be viewed.] While revising your submission, please upload your figure files to the Preflight Analysis and Conversion Engine (PACE) digital diagnostic tool, https://pacev2.apexcovantage.com/. PACE helps ensure that figures meet PLOS requirements. To use PACE, you must first register as a user. Registration is free. Then, login and navigate to the UPLOAD tab, where you will find detailed instructions on how to use the tool. If you encounter any issues or have any questions when using PACE, please email us at figures@plos.org. Please note that Supporting Information files do not need this step.
|
| Revision 1 |
|
A GPU-Based Caching Strategy for Multi-Material Linear Elastic FEM on Regular Grids PONE-D-20-11213R1 Dear Prof. Dr. Dahmen, We’re pleased to inform you that your manuscript has been judged scientifically suitable for publication and will be formally accepted for publication once it meets all outstanding technical requirements. Within one week, you’ll receive an e-mail detailing the required amendments. When these have been addressed, you’ll receive a formal acceptance letter and your manuscript will be scheduled for publication. An invoice for payment will follow shortly after the formal acceptance. To ensure an efficient process, please log into Editorial Manager at http://www.editorialmanager.com/pone/, click the 'Update My Information' link at the top of the page, and double check that your user information is up-to-date. If you have any billing related questions, please contact our Author Billing department directly at authorbilling@plos.org. If your institution or institutions have a press office, please notify them about your upcoming paper to help maximize its impact. If they’ll be preparing press materials, please inform our press team as soon as possible -- no later than 48 hours after receiving the formal acceptance. Your manuscript will remain under strict press embargo until 2 pm Eastern Time on the date of publication. For more information, please contact onepress@plos.org. Kind regards, Anotida Madzvamuse, Dphil, MSc, MSC-ED, BSc (Hon) Academic Editor PLOS ONE |
| Formally Accepted |
|
PONE-D-20-11213R1 A GPU-based caching strategy for multi-material linear elastic FEM on regular grids Dear Dr. Dahmen: I'm pleased to inform you that your manuscript has been deemed suitable for publication in PLOS ONE. Congratulations! Your manuscript is now with our production department. If your institution or institutions have a press office, please let them know about your upcoming paper now to help maximize its impact. If they'll be preparing press materials, please inform our press team within the next 48 hours. Your manuscript will remain under strict press embargo until 2 pm Eastern Time on the date of publication. For more information please contact onepress@plos.org. If we can help with anything else, please email us at plosone@plos.org. Thank you for submitting your work to PLOS ONE and supporting open access. Kind regards, PLOS ONE Editorial Office Staff on behalf of Professor Anotida Madzvamuse Academic Editor PLOS ONE |
Open letter on the publication of peer review reports
PLOS recognizes the benefits of transparency in the peer review process. Therefore, we enable the publication of all of the content of peer review and author responses alongside final, published articles. Reviewers remain anonymous, unless they choose to reveal their names.
We encourage other journals to join us in this initiative. We hope that our action inspires the community, including researchers, research funders, and research institutions, to recognize the benefits of published peer review reports for all parts of the research system.
Learn more at ASAPbio .